Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set the font in Drawing::measure #165

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Don't set the font in Drawing::measure #165

merged 1 commit into from
Mar 17, 2025
+4 −2

Conversation

fedejeanne
Copy link

Set it in Drawing::getTextExtent.

See #164 (comment)

@fedejeanne
Don't set the font in Drawing::measure
d8cd654 
Set it in Drawing::getTextExtent
@fedejeanne fedejeanne requested a review from tmssngr March 14, 2025 20:35
@github-actions GitHub Actions
Copy link

Test Results

   341 files  ±0     341 suites  ±0   2m 22s ⏱️ -1s
 3 955 tests ±0   3 671 ✅ ±0  284 💤 ±0  0 ❌ ±0 
11 693 runs  ±0  10 808 ✅ ±0  885 💤 ±0  0 ❌ ±0 

Results for commit d8cd654. ± Comparison against base commit 4f08da9.

@fedejeanne fedejeanne marked this pull request as ready for review March 14, 2025 20:57
@fedejeanne fedejeanne mentioned this pull request Mar 14, 2025
Closed
@tmssngr
Copy link

tmssngr commented Mar 15, 2025

Yes, makes sense.

tmssngr
tmssngr approved these changes Mar 15, 2025
View reviewed changes
Copy link

@tmssngr tmssngr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me.

@fedejeanne fedejeanne merged commit 81595b9 into master Mar 17, 2025
5 checks passed
@fedejeanne fedejeanne deleted the setfont_gettextextent branch March 17, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmssngr tmssngr tmssngr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedejeanne @tmssngr