Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release-tools Module for Mage Build #158

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Use release-tools Module for Mage Build #158

merged 1 commit into from
Oct 3, 2021

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Oct 1, 2021

Use github.com/sylabs/release-tools, replacing github.com/sylabs/sif/v2/internal/pkg/git and simplifying the logic in magefile.go.

@tri-adam tri-adam self-assigned this Oct 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #158 (b97cb95) into master (f9e58a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          28       28           
  Lines        2419     2419           
=======================================
  Hits         1821     1821           
  Misses        459      459           
  Partials      139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e58a4...b97cb95. Read the comment docs.

@tri-adam tri-adam marked this pull request as ready for review October 1, 2021 20:53
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit 1989014 into sylabs:master Oct 3, 2021
@tri-adam tri-adam deleted the release-tools branch October 3, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants