Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable errorlint Linter #160

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Enable errorlint Linter #160

merged 1 commit into from
Oct 21, 2021

Conversation

tri-adam
Copy link
Member

Enable errorlint linter, which finds code that will cause problems with the error wrapping scheme introduced in Go 1.13. Fix related lint.

@tri-adam tri-adam self-assigned this Oct 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #160 (a6d8c41) into master (55a90f0) will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   75.13%   75.13%           
=======================================
  Files          28       28           
  Lines        2441     2441           
=======================================
  Hits         1834     1834           
  Misses        466      466           
  Partials      141      141           
Impacted Files Coverage Δ
pkg/integrity/metadata.go 58.51% <0.00%> (ø)
pkg/integrity/select.go 68.22% <50.00%> (ø)
pkg/sif/descriptor_input.go 84.41% <50.00%> (ø)
pkg/integrity/verify.go 78.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a90f0...a6d8c41. Read the comment docs.

@tri-adam tri-adam marked this pull request as ready for review October 21, 2021 13:16
@tri-adam tri-adam merged commit e0f770a into sylabs:master Oct 21, 2021
@tri-adam tri-adam deleted the errorlint branch October 21, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants