-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] PostgreSQL: Initial commis to support Prepared Statements #4836
Draft
renecannao
wants to merge
33
commits into
v3.0
Choose a base branch
from
v2.x_pg_PrepStmtBase_240714
base: v3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added class Base_STMT_Global_info
Also adding new debug modules
process_mysql_query() extract queries at different offsets depending if: * MySQL (COM_QUERY, COM_STMT_PREPARE, COM_STMT_EXECUTE) * PostgreSQL (Simple query) * PostgreSQL (PARSE)
Not working, just placeholders
PgSQL_Connection.cpp now includes extra header to access PostgreSQL internals. To achieve that some postgres headers were modified, and ProxySQL code needs to define PG_SYM_PROXYSQL (see PgSQL_Connection.cpp as example).
Use of PQsendQueryPrepared() instead of PQsendQueryParams() . PQsendQueryParams() sends also a Parse packet , but we had the query already parsed . Fixed how resultFormat is evaluated. Hardcoded stmtName `proxysql_ps_1` : this is temporary
Nothing significant
It still doesn't link, WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.