Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pom.xml for FreeBSD support #475

Closed
wants to merge 1 commit into from
Closed

Update pom.xml for FreeBSD support #475

wants to merge 1 commit into from

Conversation

achix
Copy link
Contributor

@achix achix commented Nov 29, 2023 •
edited
Loading

Update pom.xml for FreeBSD support, tested with java 11 and java 17

@achix
Update pom.xml for FreeBSD suppost
615b258 
Update pom.xml for FreeBSD suppost, tested with java 11 and java 17
@achix achix changed the title Update pom.xml for FreeBSD suppost Update pom.xml for FreeBSD support Nov 29, 2023
@jcflack
Copy link
Contributor

jcflack commented Dec 22, 2023

Hello,

Thank you for the contribution!

May I ask you to review the documentation file src/site/markdown/build/freebsd.md to possibly remove any outdated information and add any relevant new notes, and commit those changes also on this branch?

Thanks again.

@achix
Copy link
Contributor Author

achix commented Dec 23, 2023

Hello,

Thank you for the contribution!

May I ask you to review the documentation file src/site/markdown/build/freebsd.md to possibly remove any outdated information and add any relevant new notes, and commit those changes also on this branch?

Thanks again.

Hello, thank you for considering my patch! src/site/markdown/build/freebsd.md is outdated in its whole. Once the pom.xml is updated for FreeBSD support, I don't think there is any other special consideration that I recall. Just a note in src/site/markdown/build/freebsd.md like : The build process is the same as in other Unix systems such Linux. would suffice IMHO.

jcflack added a commit that referenced this pull request Mar 25, 2024
@jcflack
PR #475 from Achilleas Mantzios rebased
99a1daa 
... with build/freebsd.md updated accordingly.
@jcflack jcflack mentioned this pull request Mar 25, 2024
Merged
@jcflack
Copy link
Contributor

jcflack commented Mar 25, 2024

Closing this PR; rebased as #478.

@jcflack jcflack closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achix @jcflack