-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[work-in-progress]: Perform all decoding internally #420
Conversation
@Mingun seriously I need some feedback on the plan. It would conflict with or render pointless a lot of other changes. |
ac63646
to
a676d30
Compare
I'm going to sleep now, I'll give my thoughts later. General note: I prefer moving by small steps, first preparing the necessary infrastructure. To begin with, I suggest looking at #421 first |
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
- Coverage 49.53% 48.16% -1.38%
==========================================
Files 22 22
Lines 13856 13673 -183
==========================================
- Hits 6864 6586 -278
- Misses 6992 7087 +95
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2a9803c
to
6b4a32b
Compare
I would be fine with merging the commits incrementally. |
@Mingun These 5 commits are "ready", if you would like to review them now. There is a lot of temporary hacks in here that are already gone in the full patch series, but it would be an extra 1000+ lines added to this, and big PRs suck to review. There are more patches here which mostly complete the transition to utf8 types, however, |
false, | ||
)) | ||
)) // TODO(dalley): this is temporary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these temporaries are already gone later in the patch series, but as I said, it's another 1000 lines of changes
Changing approach, working on top of the first half of the async PR. |
&str
/String
/Cow<str>
rather than raw bytesunsafe fn std::str::from_utf8_unchecked()
, which would not incur any overhead