-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reveal size, mtime of all files in a folder #478
Conversation
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 87.98% 91.46% +3.47%
==========================================
Files 35 35
Lines 2955 2963 +8
Branches 339 339
==========================================
+ Hits 2600 2710 +110
+ Misses 280 181 -99
+ Partials 75 72 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good once get_all_current_snapshot_pathstates is changed to return a list or dict. I agree that it would be better to avoid allocating one, but I can't think of an easy to do so without providing a footgun re: transactions here.
fixes #476