Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal size, mtime of all files in a folder #478

Merged
merged 11 commits into from
Jul 9, 2021

Conversation

meejah
Copy link
Collaborator

@meejah meejah commented Jul 7, 2021

fixes #476

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #478 (d779057) into main (165a553) will increase coverage by 3.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   87.98%   91.46%   +3.47%     
==========================================
  Files          35       35              
  Lines        2955     2963       +8     
  Branches      339      339              
==========================================
+ Hits         2600     2710     +110     
+ Misses        280      181      -99     
+ Partials       75       72       -3     
Flag Coverage Δ
integration 70.50% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/magic_folder/config.py 97.77% <100.00%> (+0.26%) ⬆️
src/magic_folder/web.py 98.23% <100.00%> (+0.03%) ⬆️
src/magic_folder/downloader.py 96.06% <0.00%> (+0.43%) ⬆️
src/magic_folder/uploader.py 95.94% <0.00%> (+0.67%) ⬆️
src/magic_folder/snapshot.py 95.48% <0.00%> (+1.12%) ⬆️
src/magic_folder/client.py 96.47% <0.00%> (+1.17%) ⬆️
src/magic_folder/api_cli.py 90.55% <0.00%> (+3.33%) ⬆️
src/magic_folder/cli.py 68.59% <0.00%> (+9.74%) ⬆️
src/magic_folder/util/eliotutil.py 89.18% <0.00%> (+14.18%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165a553...d779057. Read the comment docs.

Copy link
Contributor

@tomprince tomprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good once get_all_current_snapshot_pathstates is changed to return a list or dict. I agree that it would be better to avoid allocating one, but I can't think of an easy to do so without providing a footgun re: transactions here.

@meejah meejah merged commit b9845af into tahoe-lafs:main Jul 9, 2021
@meejah meejah deleted the 476.per-file-info branch July 9, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP API to retrieve all file statuses for a given folder
2 participants