fix: fix Specta integration #12371
Merged
fix: fix Specta integration #12371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 12f3a9aNo changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
approved these changes
Jan 12, 2025
FabianLars
added a commit
that referenced
this pull request
Jan 13, 2025
FabianLars
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #11871 as it has created an implicit version lock on Specta
=2.0.0-rc.20for everyone with Tauri in their crate graph which means I am unable to roll out a fix for the issue that it was intended to workaround.Tauri has an unlocked Specta version so it will automatically work with the latest version however,
specta-utillocks itself to a specific Specta version. Tauri does have the version ofspecta-utilunlocked so theorically Cargo should pull the latest version of it which in turn should use the latest Specta version but for some reason in my local testing this is not the case.The previous PR also bumped the lowest supported version of Specta in a minor release which I think is a semver breaking change so i've reverted it too.