Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type: module #11

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Add type: module #11

merged 4 commits into from
Dec 13, 2022

Conversation

sidharthv96
Copy link
Collaborator

@sidharthv96 sidharthv96 commented Dec 12, 2022

dagre-d3-es doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix.

Error found in mermaid-js/mermaid-live-editor#1119

Another error

SyntaxError: Named export 'addHtmlLabel' not found. The requested module 'dagre-d3-es/src/dagre-js/label/add-html-label.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'dagre-d3-es/src/dagre-js/label/add-html-label.js';
const { addHtmlLabel: addHtmlLabel$1 } = pkg;

* upstream/main:
  style: add a .prettierrc.js file
  ci: add a basic lint GitHub Action for prettier
  prettier
  v7.0.5
  v7.0.4
  chore: update typescript lib
  add intersect index
  add intersect index
@tbo47 tbo47 merged commit fdb7552 into tbo47:main Dec 13, 2022
@sidharthv96
Copy link
Collaborator Author

Thank you @tbo47 !

@tbo47
Copy link
Owner

tbo47 commented Dec 14, 2022

Thanks to you @sidharthv96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants