Skip to content
This repository has been archived by the owner on Feb 4, 2024. It is now read-only.

Support fragment #232

Merged
merged 10 commits into from
Jul 6, 2018
Merged

Support fragment #232

merged 10 commits into from
Jul 6, 2018

Conversation

epool
Copy link
Collaborator

@epool epool commented Jul 4, 2018

This PR fixes #128 since android.app.Fragment was deprecated.

@tbruyelle This must be reviewed and merged after #231 . We could do a new release just after these two PRs I guess.

@epool epool requested a review from tbruyelle July 4, 2018 02:21
* Update libraries to latest versions.

* Move from bintray to jitpack.

* Update travis file.
Copy link
Owner

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you fix the conflicts and merge (I can't do it with my current setup) ?
Thanks

@epool
Copy link
Collaborator Author

epool commented Jul 6, 2018

@tbruyelle

Sure, I'll rebase máster in a while. Do you want to do a new version release? 0.10.0 perhaps or 0.9.6?

@tbruyelle
Copy link
Owner

Yes 0.10.0 definitively to underline the repo change. Good idea.

@epool epool merged commit d31e5dd into tbruyelle:master Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RxPermissionsFragments extend support library Fragment
2 participants