Editorial: EvaluateClassStaticBlockBody cannot throw during function instantiation #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Feb 14, 2024
michaelficarra
approved these changes
Feb 14, 2024
bakkot
force-pushed
the
evaluation-empty-static-block
branch
from
25de6ee to
c23f1b7
Compare
bakkot
added
the
ready to merge
…instantiation (#2931) FunctionDeclarationInstantiation only throws if there is a parameter expression (computed member in destructuring, or default value) which throws. In this case the "function object" being evaluated is a synthetic value created by ClassStaticBlockDefinitionEvaluation which is used to explain how static blocks work. This synthetic value does not have any parameters, so FunctionDeclarationInstantiation on it cannot throw.
ljharb
force-pushed
the
evaluation-empty-static-block
branch
from
c23f1b7 to
e20763a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a
?to a!in EvaluateClassStaticBlockBody.FunctionDeclarationInstantiation only throws if there is a parameter expression (computed member in destructuring, or default value) which throws. In this case the "function object" being evaluated is a synthetic value created by ClassStaticBlockDefinitionEvaluation which is used to explain how static blocks work (threaded through from ClassDefinitionEvaluation step 31.b.ii). This synthetic value does not have any parameters, so FunctionDeclarationInstantiation on it cannot throw.