Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cached bundle files read-only #14

Closed
pkgw opened this issue Mar 16, 2017 · 0 comments
Closed

Make cached bundle files read-only #14

pkgw opened this issue Mar 16, 2017 · 0 comments
Labels
good first issue A good issue for new contributors to try tackling!

Comments

@pkgw
Copy link
Collaborator

pkgw commented Mar 16, 2017

The relevant API has stabilized in 1.16.0, I think: here.
@pkgw pkgw added the good first issue A good issue for new contributors to try tackling! label Mar 17, 2017
alexander-bauer added a commit to alexander-bauer/tectonic that referenced this issue Jun 2, 2017
@alexander-bauer
Make cache files readonly
c1edbad 
- After moving new cache files to their final destination, set their
  permissions to have `readonly` set `true`.
- This uses `fs::set_permissions` rather than the suggested
  ``fs::File::set_permissions`, because the latter would require the final
  file to be open. We cannot change the permissions on the tempfile in
  this way, because `mkstemp::TempFile` doesn't have the same
  `set_permissions` method.

Close tectonic-typesetting#14
@alexander-bauer alexander-bauer mentioned this issue Jun 2, 2017
Merged
@pkgw pkgw closed this as completed in #55 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good issue for new contributors to try tackling!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pkgw