Get the test suite running on Windows #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This macro was being used in a gross way to hide an offset in the array indexing. Make it a bit clearer what's going on, and importantly change some magic hardcoded numbers into symbolic constants. Also fix an off-by-one in the size that was exposed in the port to Winows.
Could probably remove some of these #includes outright, but at the moment it's easier just to #ifdef them.
In particular, on Windows we force static linking, since the DLL loading story is *gross*.
First, there's a quirk about file locking that we need to work around. Second, we need to add a racy check to the code that saves files under their MD5sum names, since on Windows we can't rename one file onto another file that's read-only.
Windows provides a getenv() call but it seems that it only looks at libc-internal data structures, such that we don't see the values of environment variables changed at runtime through Rust. This breaks the test suite. So, use GetEnvironmentVariable instead.
Of course, all file I/O should be going through Rust, so *really* we should be ripping this code out. But I want to get us working on Windows and this seems like the fastest path forward.
This is more code that should probably disappear anyway -- I think it only exists for shelling out to Ghostscript and other stuff along those lines that we definitely don't want to do in Tectonic. It used <dirent.h> and so was going to be annoying to compile on Windows, so, sayonara.
This shelled out to Ghostscript to calculate bounding boxes or something. There's no way we wanted to do that anyway, so kill the code. It wouldn't build on Windows due to the use of popen().
pkgw
changed the title
Closed
Mrmaxmeier
added a commit
to Mrmaxmeier/tectonic
that referenced
this pull request
Dec 13, 2019
fix JPEG_get_iccp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least, on my test rig. Will AppVeyor like it???