Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes alibabacloud-go/cr-20160607 license #1301

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fixes alibabacloud-go/cr-20160607 license #1301

merged 1 commit into from
Feb 10, 2025

Conversation

PuneetPunamiya
Copy link
Member

  • This patch fixes alibabacloud-go/cr-20160607 license using a fork + replace, to take over the LICENSE check by replacing github.com/alibabacloud-go/cr-20160607 => github.com/vdemeester/cr-20160607 v1.0.1

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2025
@PuneetPunamiya
Fixes alibabacloud-go/cr-20160607 license
935a58c 
- This patch fixes alibabacloud-go/cr-20160607 license using a fork + replace, to take over the LICENSE check
  by replacing github.com/alibabacloud-go/cr-20160607 => github.com/vdemeester/cr-20160607 v1.0.1

- Removes golang lint check from presubmit.sh as lint check is done in
  the workflow

Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2025
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
lcarva
lcarva approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@tekton-robot tekton-robot merged commit c7590b6 into tektoncd:main Feb 10, 2025
16 checks passed
@PuneetPunamiya PuneetPunamiya mentioned this pull request Feb 10, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@lcarva lcarva lcarva approved these changes

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@vdemeester vdemeester

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PuneetPunamiya @vdemeester @tekton-robot @lcarva