-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0044]: Refocus on Execution Options #610
Conversation
35301ce
to
ffbfcb1
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the problem statement @lbernick, much clearer now! 🎉
ffbfcb1
to
90a3d26
Compare
/assign bobcatfish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update on this @lbernick.
The new TEP name seems fine to me, however the summary suggests that the execution mode must be controlled by the user that executes the pipeline.
I'm not convinced that that must be the case though. I agree we might give that control to users, but I would like to consider options where the Tekton controller makes some smart choices based about how execute a pipeline, rather than leaving it to the user by default.
90a3d26
to
a40894d
Compare
Thanks for the feedback! I've updated the summary to simply say that we want more options for how to execute pipelines, and tweaked the requirements wording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
/approve
/kind tep |
I have 2 pieces of feedback but don't need to necessarily block this PR:
Anyway hoping we can talk some of this through in the API WG on Monday and I'm expecting I'll do an approve shortly after that! |
This commit renames TEP-0044 to "Data Locality and Pod Overhead in Pipelines" and re-focuses it on giving users more control over how their Pipelines are executed. There are two reasons for this change: - The problems identified with how Tasks are executed (pod overhead and difficulty passing data between Tasks) are relevant only when executing multiple Tasks together, not when a single Task is executed in a TaskRun. - The title "Decoupling Scheduling from Execution" implies that we must choose a runtime-based configuration for Pipeline execution. This commit clarifies that while execution options must be configurable at runtime, we may choose to also make them configurable at authoring time in the future.
a40894d
to
caa60c9
Compare
I've updated the title to "Data Locality and Pod Overhead in Pipelines". A bit long, but this is the closest description I could come up with to the problem we are trying to solve. Makes it clear that the problem is with Pipelines rather than Tasks, doesn't imply runtime vs authoring time configuration, and doesn't expand the scope as much as the previous title.
I don't think this was completely resolved at the WG, but I also don't think this PR should be blocked on resolving this question. |
Thanks @lbernick ! :D For me that's an: /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, bobcatfish, jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm approved to be merged outside of api wg in slack thread thanks @lbernick! |
This commit renames TEP-0044 to "More Execution Options for Pipelines" and re-focuses it on giving
users more control over how their Pipelines are executed. There are two reasons for this change:
are relevant only when executing multiple Tasks together, not when a single Task is executed in a TaskRun.
for Pipeline execution. This commit clarifies that while execution options must be configurable at runtime,
we may choose to also make them configurable at authoring time.