Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0096]: Remove OCI bundle syntax in V1 #755

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

lbernick
Copy link
Member

This change proposes removing OCI bundle syntax in v1, as remote resolution
replaces the OCI bundles feature.

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Jul 12, 2022
@lbernick
Copy link
Member Author

/assign @vdemeester

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@jerop
Copy link
Member

jerop commented Jul 13, 2022

/assign
/assign @vdemeester

@jerop
Copy link
Member

jerop commented Jul 18, 2022

API WG on 07/18: Reach out to tekton-dev@ to gather user feedback, and Lee will update PR with more details about how remote resolution replaces OCI bundles (through bundles resolver)

This change proposes removing OCI bundle syntax in v1, as remote resolution
replaces the OCI bundles feature.
@lbernick
Copy link
Member Author

API WG on 07/18: Reach out to tekton-dev@ to gather user feedback, and Lee will update PR with more details about how remote resolution replaces OCI bundles (through bundles resolver)

Updated the TEP with this info. Replacing bundles with remote resolution is discussed in tektoncd/pipeline#3661 and tektoncd/pipeline#3661. It looks like in tektoncd/pipeline#5131 we are already going forward with the deprecation (which I support); I think it would be better to inform users that this will be deprecated and replaced rather than to ask for user feedback-- especially based on @abayer's comments at the WG that the resolution API may change slightly as we bring it into Pipelines. @vdemeester thoughts?

@vdemeester
Copy link
Member

Updated the TEP with this info. Replacing bundles with remote resolution is discussed in tektoncd/pipeline#3661 and tektoncd/pipeline#3661. It looks like in tektoncd/pipeline#5131 we are already going forward with the deprecation (which I support); I think it would be better to inform users that this will be deprecated and replaced rather than to ask for user feedback-- especially based on @abayer's comments at the WG that the resolution API may change slightly as we bring it into Pipelines. @vdemeester thoughts?

Yes, we can definitely communicate today that this will be deprecated. I don't have any rush to get tektoncd/pipeline#5131 if we think we need to get the UX right on the resolution API. I don't recall what @abayer said around what could change, but if we feel anything might change with the shape of pipelineRef/taskRef when we integrate tektoncd/resolution in tektoncd/pipeline, then we should definitely wait for those changes before officially deprecated taskref.bundle.

@abayer
Copy link
Contributor

abayer commented Jul 22, 2022

Based on my work so far, I don't think there'll be any API changes for resolution, but we'll see. =) In general, I'd say wait for resolution to land in Pipeline - that should be done in v0.39.0, so we can deprecate taskref.bundle in that release as well.

@abayer
Copy link
Contributor

abayer commented Jul 25, 2022

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@tekton-robot tekton-robot merged commit 271b7dc into tektoncd:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: UnAssigned
Development

Successfully merging this pull request may close these issues.

6 participants