Change the interface of the PullRequest resource to be more granular.

[dlorenc]

Changes

Currently the PullRequest resource produces one large json object representing the
entire PR. This works, but makes it harder to write simple programs to manipulate this
object.

This commit changes this interface to produce a set of files, each representing a part
of the initial pull request. This makes it easier for programs to do simple tasks like add
labels or comments.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

 The pullRequest resource type now outputs and expects files in a slightly different format. The new format can be found [here](TODO).

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlorenc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	72.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[bobcatfish]

I like that we're breaking this up and making it more granular! I think the logic itself could be made even more granular if you're up for it.

I think there are a couple of doc changes that need to go along with this:

• https://github.com/tektoncd/pipeline/blob/master/docs/resources.md#pull-request-resource
• https://github.com/tektoncd/pipeline/tree/master/cmd/pullrequest-init#pullrequest-init
  (Feels like those 2 docs repeat each other a bit, so if you want the README to link to the resources doc that could be good - whatever you think is best!)

What do you think if we also included something in examples that maybe just read from a PR in a public repo?

[dlorenc]

What do you think if we also included something in examples that maybe just read from a PR in a public repo?

Yea, I'm going to add that one as a separate PR along with an integration test.

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	74.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[dlorenc]

I think there are a couple of doc changes that need to go along with this:

• https://github.com/tektoncd/pipeline/blob/master/docs/resources.md#pull-request-resource
• https://github.com/tektoncd/pipeline/tree/master/cmd/pullrequest-init#pullrequest-init
  (Feels like those 2 docs repeat each other a bit, so if you want the README to link to the resources doc that could be good - whatever you think is best!)

Done!

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	74.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[bobcatfish]

wooooot

[bobcatfish]

im gonna assume my unit test rhetoric did not convince you XD

/lgtm
/meow space

[bobcatfish]

nice updates!

[tekton-robot]

@bobcatfish:

In response to this:

im gonna assume my unit test rhetoric did not convince you XD

/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/pullrequest-init/disk.go	Do not exist	74.8%
cmd/pullrequest-init/github.go	83.5%	83.5%	0.0

[bobcatfish]

/lgtm