-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaniko test follow up #1558
Kaniko test follow up #1558
Conversation
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
It seems `kaniko` needs to be run as root to work, so be explicit about it. This is especially useful on kubernetes distribution that default to run as user (like OpenShift). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Explaining why we are using a pod and skopeo. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
The following is the coverage report on pkg/.
|
Watch the deployment replicas instead and create the service only once the deployment has the correct number of replicas. This removes the need for a random 5s sleep in the middle. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
The following is the coverage report on pkg/.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Few updates on the
TeskKanikoTaskRun
.runAsUser
) as kaniko needs to be run as root. This is particularly useful on platform that default to run as random uid (like OpenShift).time.Sleep(5)
and watch the deployment replicas (expected vs read) insteadThis is a follow-up on #1516
/cc @chmouel @bobcatfish
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.