Kaniko test follow up #1558
Merged
Kaniko test follow up #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
It seems `kaniko` needs to be run as root to work, so be explicit about it. This is especially useful on kubernetes distribution that default to run as user (like OpenShift). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Explaining why we are using a pod and skopeo. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
The following is the coverage report on pkg/.
|
Watch the deployment replicas instead and create the service only once the deployment has the correct number of replicas. This removes the need for a random 5s sleep in the middle. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
size/M
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Few updates on the
TeskKanikoTaskRun.runAsUser) as kaniko needs to be run as root. This is particularly useful on platform that default to run as random uid (like OpenShift).time.Sleep(5)and watch the deployment replicas (expected vs read) insteadThis is a follow-up on #1516
/cc @chmouel @bobcatfish
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.