Move working dir initialization out to pkg/pod/ #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
|
/lgtm |
This simplifies pod.go and makes this logic more easily testable/understandable in isolation. This also removes stepTemplate merging from init containers, where users shouldn't know/care about the details of those containers anyway. This makes some simplifying changes to creds-init as well, and adds TODOs to further simplify.
imjasonh
force-pushed
the
working-dir-init
branch
from
572e43b to
5ecad24
Compare
|
Whoops, |
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies pod.go and makes this logic more easily
testable/understandable in isolation, as part of an overall plan to simplify pod.go.
This also removes stepTemplate merging from init containers, where users
shouldn't know/care about the details of those containers anyway.
This makes some simplifying changes to creds-init as well, and adds
TODOs to further simplify.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
cc @dicarlo2