Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendored version of plumbing instead of go get 🦸 #1763

Merged
merged 2 commits into from
Dec 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions hack/update-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh

SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this one wasn't slowing us down :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one wasn't, but ain't used anymore 😝

CODEGEN_PKG=${CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' k8s.io/code-generator)}

KNATIVE_CODEGEN_PKG=${KNATIVE_CODEGEN_PKG:-$(go list -m -f '{{.Dir}}' knative.dev/pkg)}
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

# generate the code with:
# --output-base because this script should also be able to run inside the vendor dir of
Expand Down
3 changes: 1 addition & 2 deletions hack/update-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

cd ${REPO_ROOT_DIR}

Expand Down
3 changes: 1 addition & 2 deletions hack/verify-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

go get -d github.com/tektoncd/plumbing
source $(go list -m -f '{{.Dir}}' github.com/tektoncd/plumbing)/scripts/library.sh
source $(dirname $0)/../vendor/github.com/tektoncd/plumbing/scripts/library.sh

readonly TMP_DIFFROOT="$(mktemp -d ${REPO_ROOT_DIR}/tmpdiffroot.XXXXXX)"

Expand Down
27 changes: 27 additions & 0 deletions test/dummy_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// +build e2e

// Copyright © 2018 The Tekton Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package test

import (
"testing"

_ "github.com/tektoncd/plumbing/scripts"
)

func TestDummy(t *testing.T) {
t.Log("This is required to make sure we get tektoncd/plumbing in the repository, folder vendor")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

}
271 changes: 271 additions & 0 deletions vendor/github.com/tektoncd/plumbing/scripts/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions vendor/github.com/tektoncd/plumbing/scripts/dummy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading