Don't assume $0 is the script source #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
chmouel
force-pushed
the
dont-assume-dollar-zero-is-topdir
branch
from
e68888a to
302610d
Compare
tekton-robot
added
size/S
chmouel
added a commit
to openshift-pipelines/plumbing
that referenced
this pull request
Jan 8, 2020
So I can get this tektoncd/pipeline#1808 until merged
imjasonh
reviewed
Jan 8, 2020
Part of our 'downstream' CI we reuse the `test/e2e-common.sh` functions, we have a script that source the test/e2e-common.sh and run with the downstream specifics functions. $0 in the e2e-common assume the script is run from `test/e2e-tests.sh` when our script which source test/e2e-tests.sh is something else somewhere else. Let's use git to safely detect the toplevel of the directory Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Following commit 2af394c there was a `go get` left which wasnt removed. Since we have it in vendor directory we don't need to donwload it again. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
chmouel
force-pushed
the
dont-assume-dollar-zero-is-topdir
branch
from
302610d to
bf11611
Compare
vdemeester
approved these changes
Jan 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't assume $0 is the script source
Part of our 'downstream' CI we reuse the
test/e2e-common.shfunctions.We have a script that source the test/e2e-common.sh and run with the downstream
specifics functions.
$0 in the e2e-common assume the script is run from
test/e2e-tests.shwhen ourscript which source test/e2e-tests.sh is something else somewhere else.
Let use git to safely detect the toplevel of the directory from where we can
source the vendor directory.
Remove latest go get from there too
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes