Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update -shell-image to a multi-arch version with s390x addition #3406

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update -shell-image to a multi-arch version with s390x addition #3406

merged 1 commit into from
Oct 21, 2020

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Oct 19, 2020

Changes

distroless has s390x support now. So update shell-image to use image sha which has amd64, arm64 and s390x support.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Use a multi-arch shell-image with amd64, arm64 and s390x support

@barthy1
Update -shell-image to a multi-arch version with s390x addition
41a2ba3 
Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 19, 2020
@tekton-robot tekton-robot requested review from bobcatfish and a user October 19, 2020 08:41
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2020
@vdemeester
Copy link
Member

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 19, 2020
@barthy1
Copy link
Member Author

barthy1 commented Oct 19, 2020

/retest

1 similar comment
@barthy1
Copy link
Member Author

barthy1 commented Oct 19, 2020

/retest

@barthy1
Copy link
Member Author

barthy1 commented Oct 20, 2020

I have EasyCLA check in progress more than 24 hours :( What I can do to pass this check?

@vdemeester vdemeester closed this Oct 20, 2020
@vdemeester vdemeester reopened this Oct 20, 2020
@vdemeester
Copy link
Member

@barthy1 usually, close/reopen force the check to be done 🙃

vdemeester
vdemeester approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
/cc @afrittoli

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
/cc @afrittoli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@dlorenc
Copy link
Contributor

dlorenc commented Oct 21, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2020
@tekton-robot tekton-robot merged commit a248495 into tektoncd:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@dlorenc dlorenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barthy1 @vdemeester @tekton-robot @dlorenc