Add SYSTEM_NAMESPACE introduction in test README #3633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recently, there is a new change in the Knative test framework:
By default, the
SYSTEM_NAMESPACE
will be set asknative-testing
:https://github.com/knative/pkg/blob/67d950c438f17c46108761215c0c8394484edea5/system/testing/names.go#L29
So Tekton introduced this change, to set
SYSTEM_NAMESPACE=tekton-pipelines
duringinstall_pipeline_crd
:https://github.com/tektoncd/pipeline/blob/master/test/e2e-common.sh#L30
But for our scenario, we deploy Tekton by ourselves and just need to run the E2E test by using
go test
directly:https://github.com/tektoncd/pipeline/tree/master/test#end-to-end-tests
But if I don't run
e2e-tests.sh
I will miss this settingSYSTEM_NAMESPACE=tekton-pipelines
which makes failure in some of E2E tests, like:Failed to get ConfigMap feature-flags: configmaps "feature-flags" not found
, because we don't haveknative-testing
namespace, so of course no configmaps "feature-flags" in there:https://github.com/tektoncd/pipeline/blob/master/test/tektonbundles_test.go#L524
So I add this
SYSTEM_NAMESPACE
in the test README to help the person who wants to run the E2E by usinggo test
directly./kind documentation
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes