Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for build-gcs and the gcs-fetcher image #3771

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

imjasonh
Copy link
Member

Changes

Fixes #3734, and implements TEP-0037 to remove support for build-gcs PipelineResources and the gcs-fetcher image, which were deprecated in the latest release v0.21.0

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [y] Includes tests (if functionality changed/added)
  • [y] Includes docs (if user facing)
  • [y] Commit messages follow commit message best practices
  • [y] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Remove support for build-gcs and the gcs-fetcher image

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 18, 2021
@tekton-robot tekton-robot requested review from dibyom and a user February 18, 2021 19:40
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 18, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 90.6% 90.2% -0.5
pkg/apis/resource/v1alpha1/storage/storage.go 95.5% 95.2% -0.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 90.6% 90.2% -0.5
pkg/apis/resource/v1alpha1/storage/storage.go 95.5% 95.2% -0.2

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 90.6% 90.2% -0.5
pkg/apis/resource/v1alpha1/storage/storage.go 95.5% 95.2% -0.2

@ghost
Copy link

ghost commented Feb 22, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Feb 22, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 90.6% 90.2% -0.5
pkg/apis/resource/v1alpha1/storage/storage.go 95.5% 95.2% -0.2

@ghost
Copy link

ghost commented Feb 22, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021
@tekton-robot tekton-robot merged commit 9bb450c into tektoncd:master Feb 22, 2021
barthy1 added a commit to barthy1/pipeline that referenced this pull request Feb 23, 2021
As per tektoncd#3771 build-gcs
support(and tests) was removed. The tests were in exclude list for
s390x. Now the list can be reduced.

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
tekton-robot pushed a commit that referenced this pull request Feb 24, 2021
As per #3771 build-gcs
support(and tests) was removed. The tests were in exclude list for
s390x. Now the list can be reduced.

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: Remove build-gcs support and gcs-fetcher image for v0.22
3 participants