-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for build-gcs and the gcs-fetcher image #3771
Conversation
The following is the coverage report on the affected files.
|
45e1cdd
to
e69a930
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e69a930
to
4af17a0
Compare
The following is the coverage report on the affected files.
|
/lgtm |
4af17a0
to
ba2ffed
Compare
The following is the coverage report on the affected files.
|
/lgtm |
As per tektoncd#3771 build-gcs support(and tests) was removed. The tests were in exclude list for s390x. Now the list can be reduced. Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
As per #3771 build-gcs support(and tests) was removed. The tests were in exclude list for s390x. Now the list can be reduced. Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
Changes
Fixes #3734, and implements TEP-0037 to remove support for
build-gcs
PipelineResources and the gcs-fetcher image, which were deprecated in the latest release v0.21.0/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes