Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to use Kubernetes 1.18 as the minimum version #3986

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Update docs to use Kubernetes 1.18 as the minimum version #3986

merged 1 commit into from
Jun 1, 2021

Conversation

jmlrt
Copy link
Contributor

@jmlrt jmlrt commented May 27, 2021 •
edited
Loading

Changes

As of v0.24, Tekton Pipelines requires Kubernetes 1.18
(https://github.com/tektoncd/pipeline/releases/tag/v0.24.0), but the docs were not updated. This updates all references of Kubernetes 1.17 to 1.18 as necessary.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 27, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 27, 2021
@tekton-robot
Copy link
Collaborator

Hi @jmlrt. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/documentation Categorizes issue or PR as related to documentation. labels May 27, 2021
@jmlrt
Update docs to use K8S 1.18 as the minimum version
a510663 
As of v0.24, Tekton Pipelines requires Kubernetes 1.18
(https://github.com/tektoncd/pipeline/releases/tag/v0.24.0), but the
docs were not updated. This updates all references of Kubernetes 1.17
to 1.18 as necessary.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2021
@jmlrt
Copy link
Contributor Author

jmlrt commented May 27, 2021

/assign @dlorenc

@AlanGreene
Copy link
Member

Thanks @jmlrt

/ok-to-test
/lgtm

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2021
@AlanGreene AlanGreene mentioned this pull request May 28, 2021
Closed
5 tasks
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@tekton-robot tekton-robot merged commit 335adda into tektoncd:main Jun 1, 2021
@jmlrt jmlrt deleted the k8s-1-18-min branch June 7, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@dlorenc dlorenc

@AlanGreene AlanGreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmlrt @tekton-robot @AlanGreene @vdemeester @dlorenc