Enabled the whitespace linter.

.golangci.yml

@@ -28,8 +28,7 @@ linters:
   - unconvert
   - depguard
   - unused
-    # TODO: enable whitespace linter
-    #- whitespace
+  - whitespace
 output:
   uniq-by-line: false
 issues:

cmd/entrypoint/subcommands/subcommands_test.go

@@ -58,7 +58,6 @@ func TestProcessSuccessfulSubcommands(t *testing.T) {
 			t.Errorf("unexpected return value from step-init command w/ params: %v", returnValue)
 		}
 	})
-
 }
 
 // TestProcessIgnoresNonSubcommands checks that any input to Process which
@@ -84,7 +83,6 @@ func TestProcessIgnoresNonSubcommands(t *testing.T) {
 	})
 
 	t.Run(DecodeScriptCommand, func(t *testing.T) {
-
 		if err := Process([]string{DecodeScriptCommand}); err != nil {
 			t.Errorf("unexpected error processing command with 0 additional args: %v", err)
 		}

cmd/imagedigestexporter/main.go

@@ -73,7 +73,6 @@ func main() {
 			Value:        imageResource.URL,
 			ResourceName: imageResource.Name,
 		})
-
 	}
 
 	if err := termination.WriteMessage(*terminationMessagePath, output); err != nil {

pkg/apis/pipeline/v1/container_types.go

@@ -22,7 +22,6 @@ import (
 
 // Step runs a subcomponent of a Task
 type Step struct {
-
 	// Name of the Step specified as a DNS_LABEL.
 	// Each Step in a Task must have a unique name.
 	Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
@@ -191,7 +190,6 @@ func (s *Step) SetContainerFields(c corev1.Container) {
 
 // StepTemplate is a template for a Step
 type StepTemplate struct {
-
 	// Image reference name.
 	// More info: https://kubernetes.io/docs/concepts/containers/images
 	// This field is optional to allow higher level config management to default or override
@@ -308,7 +306,6 @@ func (s *StepTemplate) ToK8sContainer() *corev1.Container {
 
 // Sidecar has nearly the same data structure as Step but does not have the ability to timeout.
 type Sidecar struct {
-
 	// Name of the Sidecar specified as a DNS_LABEL.
 	// Each Sidecar in a Task must have a unique name (DNS_LABEL).
 	// Cannot be updated.

pkg/apis/pipeline/v1/pipeline_validation.go

@@ -309,7 +309,6 @@ func taskContainsResult(resultExpression string, pipelineTaskNames sets.String,
 			if strings.HasPrefix(value, "finally") && !pipelineFinallyTaskNames.Has(pipelineTaskName) {
 				return false
 			}
-
 		}
 	}
 	return true

pkg/apis/pipeline/v1/pipelinerun_types_test.go

@@ -228,7 +228,6 @@ func TestPipelineRunTimeouts(t *testing.T) {
 		expectedTasksTimeout:   &metav1.Duration{Duration: 10 * time.Minute},
 		expectedFinallyTimeout: &metav1.Duration{Duration: 50 * time.Minute},
 	}, {
-
 		name:                   "pipeline and finally timeout set",
 		timeouts:               &v1.TimeoutFields{Pipeline: &metav1.Duration{Duration: time.Hour}, Finally: &metav1.Duration{Duration: 10 * time.Minute}},
 		expectedTasksTimeout:   &metav1.Duration{Duration: 50 * time.Minute},

pkg/apis/pipeline/v1/pipelinerun_validation.go

@@ -227,7 +227,6 @@ func validateSpecStatus(status PipelineRunSpecStatus) *apis.FieldError {
 		PipelineRunSpecStatusCancelledRunFinally,
 		PipelineRunSpecStatusStoppedRunFinally,
 		PipelineRunSpecStatusPending), "status")
-
 }
 
 func validateTimeoutDuration(field string, d *metav1.Duration) (errs *apis.FieldError) {

pkg/apis/pipeline/v1/result_validation_test.go

@@ -175,7 +175,6 @@ func TestResultsValidateError(t *testing.T) {
 			if d := cmp.Diff(tt.expectedError.Error(), err.Error(), cmpopts.IgnoreUnexported(apis.FieldError{})); d != "" {
 				t.Errorf("TaskSpec.Validate() errors diff %s", diff.PrintWantGot(d))
 			}
-
 		})
 	}
 }

pkg/apis/pipeline/v1/task_types.go

@@ -54,7 +54,6 @@ func (*Task) GetGroupVersionKind() schema.GroupVersionKind {
 
 // TaskSpec defines the desired state of Task.
 type TaskSpec struct {
-
 	// Params is a list of input parameters required to run the task. Params
 	// must be supplied as inputs in TaskRuns unless they declare a default
 	// value.

pkg/apis/pipeline/v1/task_validation.go

@@ -445,7 +445,6 @@ func validateStepObjectUsageAsWhole(step Step, prefix string, vars sets.String)
 	}
 	for i, arg := range step.Args {
 		errs = errs.Also(validateTaskNoObjectReferenced(arg, prefix, vars).ViaFieldIndex("args", i))
-
 	}
 	for _, env := range step.Env {
 		errs = errs.Also(validateTaskNoObjectReferenced(env.Value, prefix, vars).ViaFieldKey("env", env.Name))
@@ -475,7 +474,6 @@ func validateStepArrayUsage(step Step, prefix string, vars sets.String) *apis.Fi
 	}
 	for i, arg := range step.Args {
 		errs = errs.Also(validateTaskArraysIsolated(arg, prefix, vars).ViaFieldIndex("args", i))
-
 	}
 	for _, env := range step.Env {
 		errs = errs.Also(validateTaskNoArrayReferenced(env.Value, prefix, vars).ViaFieldKey("env", env.Name))

pkg/apis/pipeline/v1/task_validation_test.go

@@ -1518,7 +1518,6 @@ func TestStepOnError(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 // TestIncompatibleAPIVersions exercises validation of fields that

pkg/apis/pipeline/v1/workspace_validation_test.go

@@ -123,7 +123,6 @@ func TestWorkspaceBindingValidateValid(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func TestWorkspaceBindingValidateInvalid(t *testing.T) {

pkg/apis/pipeline/v1beta1/container_types.go

@@ -7,7 +7,6 @@ import (
 
 // Step runs a subcomponent of a Task
 type Step struct {
-
 	// Name of the Step specified as a DNS_LABEL.
 	// Each Step in a Task must have a unique name.
 	Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
@@ -271,7 +270,6 @@ func (s *Step) SetContainerFields(c corev1.Container) {
 
 // StepTemplate is a template for a Step
 type StepTemplate struct {
-
 	// Deprecated. This field will be removed in a future release.
 	// Default name for each Step specified as a DNS_LABEL.
 	// Each Step in a Task must have a unique name.
@@ -489,7 +487,6 @@ func (s *StepTemplate) ToK8sContainer() *corev1.Container {
 
 // Sidecar has nearly the same data structure as Step but does not have the ability to timeout.
 type Sidecar struct {
-
 	// Name of the Sidecar specified as a DNS_LABEL.
 	// Each Sidecar in a Task must have a unique name (DNS_LABEL).
 	// Cannot be updated.

pkg/apis/pipeline/v1beta1/pipeline_validation.go

@@ -315,7 +315,6 @@ func taskContainsResult(resultExpression string, pipelineTaskNames sets.String,
 			if strings.HasPrefix(value, "finally") && !pipelineFinallyTaskNames.Has(pipelineTaskName) {
 				return false
 			}
-
 		}
 	}
 	return true
@@ -425,7 +424,6 @@ func validateDeclaredResources(resources []PipelineDeclaredResource, tasks []Pip
 				required = append(required, output.Resource)
 			}
 		}
-
 	}
 	for _, t := range finalTasks {
 		if t.Resources != nil {

pkg/apis/pipeline/v1beta1/pipelinerun_types_test.go

@@ -337,7 +337,6 @@ func TestPipelineRunTimeouts(t *testing.T) {
 		expectedTasksTimeout:   &metav1.Duration{Duration: 10 * time.Minute},
 		expectedFinallyTimeout: &metav1.Duration{Duration: 50 * time.Minute},
 	}, {
-
 		name:                   "pipeline and finally timeout set",
 		timeouts:               &v1beta1.TimeoutFields{Pipeline: &metav1.Duration{Duration: time.Hour}, Finally: &metav1.Duration{Duration: 10 * time.Minute}},
 		expectedTasksTimeout:   &metav1.Duration{Duration: 50 * time.Minute},

pkg/apis/pipeline/v1beta1/pipelinerun_validation.go

@@ -270,7 +270,6 @@ func validateSpecStatus(status PipelineRunSpecStatus) *apis.FieldError {
 		PipelineRunSpecStatusCancelledRunFinally,
 		PipelineRunSpecStatusStoppedRunFinally,
 		PipelineRunSpecStatusPending), "status")
-
 }
 
 func validateTimeoutDuration(field string, d *metav1.Duration) (errs *apis.FieldError) {

pkg/apis/pipeline/v1beta1/resource_types.go

@@ -147,7 +147,6 @@ type ResultType int
 // of string, and then fail the running TaskRun because it doesn't know how to interpret
 // the string value that the TaskRun's entrypoint will emit when it completes.
 func (r *ResultType) UnmarshalJSON(data []byte) error {
-
 	var asInt int
 	var intErr error
 

pkg/apis/pipeline/v1beta1/resource_types_test.go

@@ -141,7 +141,6 @@ func TestApplyTaskModifier_AlreadyAdded(t *testing.T) {
 }
 
 func TestPipelineResourceResult_UnmarshalJSON(t *testing.T) {
-
 	testcases := []struct {
 		name string
 		data string

pkg/apis/pipeline/v1beta1/resource_types_validation.go

@@ -96,7 +96,6 @@ func validateTaskRunResources(ctx context.Context, resources []TaskResourceBindi
 		if r.ResourceSpec != nil && r.ResourceSpec.Validate(ctx) != nil {
 			return r.ResourceSpec.Validate(ctx)
 		}
-
 	}
 	return nil
 }

pkg/apis/pipeline/v1beta1/result_validation_test.go

@@ -175,7 +175,6 @@ func TestResultsValidateError(t *testing.T) {
 			if d := cmp.Diff(tt.expectedError.Error(), err.Error(), cmpopts.IgnoreUnexported(apis.FieldError{})); d != "" {
 				t.Errorf("TaskSpec.Validate() errors diff %s", diff.PrintWantGot(d))
 			}
-
 		})
 	}
 }

pkg/apis/pipeline/v1beta1/resultref.go

@@ -171,7 +171,6 @@ func stripVarSubExpression(expression string) string {
 // - Output: "", "", 0, "", error
 // TODO: may use regex for each type to handle possible reference formats
 func parseExpression(substitutionExpression string) (string, string, int, string, error) {
-
 	if looksLikeResultRef(substitutionExpression) {
 		subExpressions := strings.Split(substitutionExpression, ".")
 		// For string result: tasks.<taskName>.results.<stringResultName>

pkg/apis/pipeline/v1beta1/task_validation.go

@@ -466,7 +466,6 @@ func validateStepObjectUsageAsWhole(step Step, prefix string, vars sets.String)
 	}
 	for i, arg := range step.Args {
 		errs = errs.Also(validateTaskNoObjectReferenced(arg, prefix, vars).ViaFieldIndex("args", i))
-
 	}
 	for _, env := range step.Env {
 		errs = errs.Also(validateTaskNoObjectReferenced(env.Value, prefix, vars).ViaFieldKey("env", env.Name))
@@ -496,7 +495,6 @@ func validateStepArrayUsage(step Step, prefix string, vars sets.String) *apis.Fi
 	}
 	for i, arg := range step.Args {
 		errs = errs.Also(validateTaskArraysIsolated(arg, prefix, vars).ViaFieldIndex("args", i))
-
 	}
 	for _, env := range step.Env {
 		errs = errs.Also(validateTaskNoArrayReferenced(env.Value, prefix, vars).ViaFieldKey("env", env.Name))

pkg/apis/pipeline/v1beta1/taskrun_validation_test.go

@@ -956,7 +956,6 @@ func TestResources_Validate(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func TestResources_Invalidate(t *testing.T) {

pkg/apis/pipeline/v1beta1/workspace_validation_test.go

@@ -120,7 +120,6 @@ func TestWorkspaceBindingValidateValid(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func TestWorkspaceBindingValidateInvalid(t *testing.T) {

pkg/apis/resource/v1alpha1/pipelineresource_validation_test.go

@@ -168,7 +168,6 @@ func TestResourceValidation_Invalid(t *testing.T) {
 		}, {
 			name: "missing spec",
 			res: &v1alpha1.PipelineResource{
-
 				ObjectMeta: metav1.ObjectMeta{
 					Name: "temp",
 				},
@@ -300,5 +299,4 @@ func TestAllowedGCSStorageType(t *testing.T) {
 			}
 		})
 	}
-
 }

pkg/apis/validate/metadata_test.go

@@ -25,7 +25,6 @@ import (
 )
 
 func TestMetadataInvalidLongName(t *testing.T) {
-
 	invalidMetas := []*metav1.ObjectMeta{
 		{Name: strings.Repeat("s", validate.MaxLength+1)},
 		{Name: "bad,name"},

pkg/artifacts/artifact_storage_test.go

@@ -163,7 +163,6 @@ func TestNeedsPVC(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func TestInitializeArtifactStorage(t *testing.T) {

pkg/artifacts/artifacts_storage.go

@@ -119,7 +119,6 @@ func InitializeArtifactStorage(ctx context.Context, images pipeline.Images, pr *
 // CleanupArtifactStorage will delete the PipelineRun's artifact storage PVC if it exists. The PVC is created for using
 // an output workspace or artifacts from one Task to another Task. No other PVCs will be impacted by this cleanup.
 func CleanupArtifactStorage(ctx context.Context, pr *v1beta1.PipelineRun, c kubernetes.Interface) error {
-
 	if needsPVC(ctx) {
 		err := deletePVC(ctx, pr, c)
 		if err != nil {

pkg/internal/affinityassistant/transformer_test.go

@@ -90,7 +90,6 @@ func TestNewTransformer(t *testing.T) {
 }
 
 func TestNewTransformerWithNodeAffinity(t *testing.T) {
-
 	nodeAffinity := &corev1.NodeAffinity{
 		RequiredDuringSchedulingIgnoredDuringExecution: &corev1.NodeSelector{
 			NodeSelectorTerms: []corev1.NodeSelectorTerm{{

pkg/internal/computeresources/transformer_test.go

@@ -944,7 +944,6 @@ func cmpRequestsAndLimits(t *testing.T, want, got corev1.PodSpec) {
 		t.Errorf("Expected %d init containers, got %d", len(want.InitContainers), len(got.InitContainers))
 	} else {
 		for i, c := range got.InitContainers {
-
 			// compare name only if present in "want" so we can be sure which container gets which resources
 			if want.InitContainers[i].Name != "" {
 				if d := cmp.Diff(want.InitContainers[i].Name, c.Name); d != "" {
@@ -963,7 +962,6 @@ func cmpRequestsAndLimits(t *testing.T, want, got corev1.PodSpec) {
 		t.Errorf("Expected %d containers, got %d", len(want.Containers), len(got.Containers))
 	} else {
 		for i, c := range got.Containers {
-
 			// compare name only if present in "want" so we can be sure which container gets which resources
 			if want.Containers[i].Name != "" {
 				if d := cmp.Diff(want.Containers[i].Name, c.Name); d != "" {

pkg/pipelinerunmetrics/metrics.go

@@ -209,7 +209,6 @@ func nilInsertTag(task, taskrun string) []tag.Mutator {
 // count for number of PipelineRuns succeed or failed
 // returns an error if its failed to log the metrics
 func (r *Recorder) DurationAndCount(pr *v1beta1.PipelineRun, beforeCondition *apis.Condition) error {
-
 	if !r.initialized {
 		return fmt.Errorf("ignoring the metrics recording for %s , failed to initialize the metrics recorder", pr.Name)
 	}

pkg/pipelinerunmetrics/metrics_test.go

@@ -329,7 +329,6 @@ func TestRecordPipelineRunDurationCount(t *testing.T) {
 			} else {
 				metricstest.CheckStatsNotReported(t, "pipelinerun_count")
 			}
-
 		})
 	}
 }
@@ -374,7 +373,6 @@ func TestRecordRunningPipelineRunsCount(t *testing.T) {
 		t.Errorf("RunningPipelineRuns: %v", err)
 	}
 	metricstest.CheckLastValueData(t, "running_pipelineruns_count", map[string]string{}, 1)
-
 }
 
 func unregisterMetrics() {

pkg/pod/entrypoint_lookup.go

@@ -57,7 +57,6 @@ func resolveEntrypoints(ctx context.Context, cache EntrypointCache, namespace, s
 	// can skip lookups while resolving the same TaskRun.
 	localCache := map[name.Reference]imageData{}
 	for i, s := range steps {
-
 		// If the command is already specified, there's nothing to resolve.
 		if len(s.Command) > 0 {
 			continue

pkg/pod/entrypoint_lookup_impl_test.go

@@ -177,9 +177,7 @@ func TestGetImageWithImagePullSecrets(t *testing.T) {
 			if (err != nil) != tc.wantErr {
 				t.Fatalf("get() = %+v, %v, wantErr %t", i, err, tc.wantErr)
 			}
-
 		})
-
 	}
 }
 

pkg/pod/entrypoint_test.go

@@ -488,7 +488,6 @@ func TestEntryPointOnError(t *testing.T) {
 			}
 		})
 	}
-
 }
 
 func TestEntryPointStepOutputConfigs(t *testing.T) {

pkg/pod/pod_test.go

@@ -1279,7 +1279,6 @@ _EOF_
 		{
 			desc: "setting host aliases",
 			ts: v1beta1.TaskSpec{
-
 				Steps: []v1beta1.Step{
 					{
 						Name:    "host-aliases",
@@ -1948,7 +1947,6 @@ _EOF_
 }
 
 func TestPodBuildwithAlphaAPIEnabled(t *testing.T) {
-
 	placeScriptsContainer := corev1.Container{
 		Name:         "place-scripts",
 		Image:        "busybox",

pkg/pod/script.go

@@ -225,7 +225,6 @@ cat > ${scriptfile} << '%s'
 
 			initContainer.Args[1] += fmt.Sprintf(initScriptDirective, tmpFile, heredoc, debugScript.content, heredoc)
 		}
-
 	}
 
 	return containers