Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Pipeline validation tests into separate test classes #6653

Merged
merged 1 commit into from
May 12, 2023
Merged

Split Pipeline validation tests into separate test classes #6653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
326 changes: 174 additions & 152 deletions pkg/apis/pipeline/v1/pipeline_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,7 +1301,7 @@ func TestValidatePipelineParameterVariables_Success(t *testing.T) {
}
}

func TestValidatePipelineParameterVariables_Failure(t *testing.T) {
func TestValidatePipelineDeclaredParameterUsage_Failure(t *testing.T) {
tests := []struct {
name string
params []ParamSpec
Expand Down Expand Up @@ -1421,154 +1421,6 @@ func TestValidatePipelineParameterVariables_Failure(t *testing.T) {
Message: `non-existent variable in "$(params.does-not-exist)"`,
Paths: []string{"[0].params[b-param]"},
},
}, {
name: "invalid parameter type",
params: []ParamSpec{{
Name: "foo", Type: "invalidtype",
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `invalid value: invalidtype`,
Paths: []string{"params.foo.type"},
},
}, {
name: "array parameter mismatching default type",
params: []ParamSpec{{
Name: "foo", Type: ParamTypeArray, Default: &ParamValue{Type: ParamTypeString, StringVal: "astring"},
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `"array" type does not match default value's type: "string"`,
Paths: []string{"params.foo.default.type", "params.foo.type"},
},
}, {
name: "string parameter mismatching default type",
params: []ParamSpec{{
Name: "foo", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.foo.default.type", "params.foo.type"},
},
}, {
name: "array parameter used as string",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeString, StringVal: "$(params.baz)"},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "star array parameter used as string",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeString, StringVal: "$(params.baz[*])"},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "array parameter string template not isolated",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeArray, ArrayVal: []string{"value: $(params.baz)", "last"}},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "star array parameter string template not isolated",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeArray, ArrayVal: []string{"value: $(params.baz[*])", "last"}},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "multiple string parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString,
}, {
Name: "baz", Type: ParamTypeString,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "multiple array parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeArray,
}, {
Name: "baz", Type: ParamTypeArray,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "multiple different type parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeArray,
}, {
Name: "baz", Type: ParamTypeString,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "invalid pipeline task with a matrix parameter which is missing from the param declarations",
tasks: []PipelineTask{{
Expand Down Expand Up @@ -1784,6 +1636,179 @@ func TestValidatePipelineParameterVariables_Failure(t *testing.T) {
Paths: []string{"[0].matrix.params[b-param].value[0]"},
},
api: "alpha",
}}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctx := context.Background()
if tt.api == "alpha" {
ctx = config.EnableAlphaAPIFields(context.Background())
}
ctx = config.SkipValidationDueToPropagatedParametersAndWorkspaces(ctx, false)
err := ValidatePipelineParameterVariables(ctx, tt.tasks, tt.params)
if err == nil {
t.Errorf("Pipeline.ValidatePipelineParameterVariables() did not return error for invalid pipeline parameters")
}
if d := cmp.Diff(tt.expectedError.Error(), err.Error(), cmpopts.IgnoreUnexported(apis.FieldError{})); d != "" {
t.Errorf("PipelineSpec.Validate() errors diff %s", diff.PrintWantGot(d))
}
})
}
}

func TestValidatePipelineParameterVariables_Failure(t *testing.T) {
tests := []struct {
name string
params []ParamSpec
tasks []PipelineTask
expectedError apis.FieldError
}{{
name: "invalid parameter type",
params: []ParamSpec{{
Name: "foo", Type: "invalidtype",
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `invalid value: invalidtype`,
Paths: []string{"params.foo.type"},
},
}, {
name: "array parameter mismatching default type",
params: []ParamSpec{{
Name: "foo", Type: ParamTypeArray, Default: &ParamValue{Type: ParamTypeString, StringVal: "astring"},
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `"array" type does not match default value's type: "string"`,
Paths: []string{"params.foo.default.type", "params.foo.type"},
},
}, {
name: "string parameter mismatching default type",
params: []ParamSpec{{
Name: "foo", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.foo.default.type", "params.foo.type"},
},
}, {
name: "array parameter used as string",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeString, StringVal: "$(params.baz)"},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "star array parameter used as string",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeString, StringVal: "$(params.baz[*])"},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "array parameter string template not isolated",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeArray, ArrayVal: []string{"value: $(params.baz)", "last"}},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "star array parameter string template not isolated",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString, Default: &ParamValue{Type: ParamTypeArray, ArrayVal: []string{"anarray", "elements"}},
}},
tasks: []PipelineTask{{
Name: "bar",
TaskRef: &TaskRef{Name: "bar-task"},
Params: Params{{
Name: "a-param", Value: ParamValue{Type: ParamTypeArray, ArrayVal: []string{"value: $(params.baz[*])", "last"}},
}},
}},
expectedError: apis.FieldError{
Message: `"string" type does not match default value's type: "array"`,
Paths: []string{"params.baz.default.type", "params.baz.type"},
},
}, {
name: "multiple string parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeString,
}, {
Name: "baz", Type: ParamTypeString,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "multiple array parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeArray,
}, {
Name: "baz", Type: ParamTypeArray,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "multiple different type parameters with the same name",
params: []ParamSpec{{
Name: "baz", Type: ParamTypeArray,
}, {
Name: "baz", Type: ParamTypeString,
}},
tasks: []PipelineTask{{
Name: "foo",
TaskRef: &TaskRef{Name: "foo-task"},
}},
expectedError: apis.FieldError{
Message: `parameter appears more than once`,
Paths: []string{"params[baz]"},
},
}, {
name: "invalid task use duplicate parameters",
tasks: []PipelineTask{{
Expand All @@ -1805,9 +1830,6 @@ func TestValidatePipelineParameterVariables_Failure(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctx := context.Background()
if tt.api == "alpha" {
ctx = config.EnableAlphaAPIFields(context.Background())
}
ctx = config.SkipValidationDueToPropagatedParametersAndWorkspaces(ctx, false)
err := ValidatePipelineParameterVariables(ctx, tt.tasks, tt.params)
if err == nil {
Expand Down
Loading