Enforce Default TaskRun Timeout #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
ghost
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
approved
|
test added |
tekton-robot
added
size/L
ghost
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
The TaskRun spec describes a default timeout of ten minutes but this isn't documented anywhere else or enforced by the TaskRun reconciler. This commit: - updates the docs for TaskRuns to make the default timeout clear for users - changes the taskrun reconciler to use the default timeout if one isn't specified in the TaskRun yaml - adds a test to check whether the taskrun reconciler's checkTimeout() function is failing taskruns running longer than 10 minutes
ghost
commented
May 16, 2019
| @@ -1289,7 +1289,7 @@ func TestReconcileOnCompletedTaskRun(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatalf("Expected completed TaskRun %s to exist but instead got error when getting it: %v", taskRun.Name, err) | |||
| } | |||
| if d := cmp.Diff(newTr.Status.GetCondition(apis.ConditionSucceeded), taskSt, ignoreLastTransitionTime); d != "" { | |||
| if d := cmp.Diff(taskSt, newTr.Status.GetCondition(apis.ConditionSucceeded), ignoreLastTransitionTime); d != "" { | |||
There was a problem hiding this comment.
Tweaked this and line 1328 because the -want, +got results were backwards.
|
/lgtm |
dibyom
approved these changes
May 16, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ghost
deleted the
bobcatfish
added a commit
to bobcatfish/pipeline
that referenced
this pull request
Aug 19, 2019
Scott has been provided super detailed helpful reviews for a while now (58 reviews as of https://tekton.devstats.cd.foundation/d/46/pr-reviews-by-contributor?orgId=1&var-period=d&var-repo_name=tektoncd%2Fpipeline&var-reviewers="sbwsg"). He has contributed useful and technically challenging features such as tektoncd#905 (recreate pods in face of ResourceQuota errors), drove completion of tektoncd#936 (Graceful sidecar support) and also tektoncd#871 (enforcing default TaskRun timeouts).
tekton-robot
pushed a commit
that referenced
this pull request
Aug 26, 2019
Scott has been provided super detailed helpful reviews for a while now (58 reviews as of https://tekton.devstats.cd.foundation/d/46/pr-reviews-by-contributor?orgId=1&var-period=d&var-repo_name=tektoncd%2Fpipeline&var-reviewers="sbwsg"). He has contributed useful and technically challenging features such as #905 (recreate pods in face of ResourceQuota errors), drove completion of #936 (Graceful sidecar support) and also #871 (enforcing default TaskRun timeouts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The TaskRun spec describes a default timeout of ten minutes but this isn't documented anywhere else or enforced by the TaskRun reconciler.
This commit:
Before, TaskRuns don't timeout after ten minutes:
After, TaskRuns timeout after ten minutes by default:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes