Add an archival queue factory #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
5210cf3 to
e637864
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
2 times, most recently
from
6e8c94f to
c93f864
Compare
MichaelSnowden
changed the base branch from
durable-archival/queue-factory-base
to
da-q-processors
yycptt
reviewed
Nov 29, 2022
MichaelSnowden
force-pushed
the
da-q-processors
branch
from
2a28663 to
9bc7a96
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
c93f864 to
055eed6
Compare
MichaelSnowden
force-pushed
the
da-q-processors
branch
from
9bc7a96 to
0457a6d
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
055eed6 to
dd30d67
Compare
yycptt
approved these changes
Dec 2, 2022
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
dd30d67 to
698e70e
Compare
MichaelSnowden
force-pushed
the
da-q-processors
branch
2 times, most recently
from
6ab08a1 to
3ecd20b
Compare
|
nit: archival_queue_task_executor_test.go and archival_queue_task_executor.go |
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
698e70e to
274bfe0
Compare
MichaelSnowden
force-pushed
the
da-q-processors
branch
2 times, most recently
from
98a3a68 to
e677f15
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
274bfe0 to
2918045
Compare
Fixed (in the parent branch), and also fixed for the factory in this branch. |
MichaelSnowden
force-pushed
the
da-q-processors
branch
3 times, most recently
from
9ee1de8 to
84a8be9
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
2 times, most recently
from
60eacbf to
d082323
Compare
MichaelSnowden
force-pushed
the
da-q-processors
branch
3 times, most recently
from
604cc96 to
7e0a1b3
Compare
MichaelSnowden
force-pushed
the
durable-archival/queue-factory
branch
from
d082323 to
384a43f
Compare
MichaelSnowden
added a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds an archival queue factory to create the archival queue.
Why?
I made this change to instantiate the archival queue.
How did you test it?
I added a unit test.
Potential risks
Not used in production.
Is hotfix candidate?
No.