Add an integration test for acquireShard #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
from
943a37a to
59278cb
Compare
MichaelSnowden
commented
Dec 1, 2022
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
from
59278cb to
202653b
Compare
yiminc
reviewed
Dec 3, 2022
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
3 times, most recently
from
9186fae to
2bbe215
Compare
yiminc
reviewed
Dec 6, 2022
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
2 times, most recently
from
13a3a55 to
30105c0
Compare
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
from
30105c0 to
23b14c7
Compare
yiminc
approved these changes
Dec 8, 2022
MichaelSnowden
force-pushed
the
acquire-shard/integration-test
branch
from
23b14c7 to
d93283d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added an integration test for the acquireShard method. To do this, I created a new targeted fault injection config.
Why?
I made this to give us more confidence in the acquireShard method.
How did you test it?
With an integration test.
Potential risks
It looks like the FaultInjection config is only propagated to the persistence config in test_cluster, not anywhere else, so I don't think there's any risk to production.
Is hotfix candidate?
No.