Add a utility for reliably fetching search attributes and memo #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about add GetMemo and GetSearchAttributes into mutable state interface? |
MichaelSnowden
force-pushed
the
dynamic-fields-fetcher
branch
from
7df7b95 to
972ba6e
Compare
Fixed, good idea! |
rodrigozhou
reviewed
Dec 5, 2022
MichaelSnowden
force-pushed
the
dynamic-fields-fetcher
branch
from
972ba6e to
18dbb5a
Compare
yux0
reviewed
Dec 6, 2022
| @@ -572,6 +573,35 @@ func (e *MutableStateImpl) GetLastWriteVersion() (int64, error) { | |||
| return common.EmptyVersion, nil | |||
| } | |||
|
|
|||
| // GetMemo returns the memo of the workflow execution. If the close execution visibility task is incomplete, this method | |||
| // fetches the memo from the mutable state. Otherwise, it fetches the memo from the visibility storage backend. | |||
| func (e *MutableStateImpl) GetMemo(ctx context.Context, visibilityManager manager.VisibilityManager) (*commonpb.Memo, error) { | |||
There was a problem hiding this comment.
You should be able to get VisibilityManager from shard?
There was a problem hiding this comment.
I wasn't able to find one
MichaelSnowden
force-pushed
the
dynamic-fields-fetcher
branch
from
18dbb5a to
b081ff5
Compare
yux0
reviewed
Dec 8, 2022
MichaelSnowden
force-pushed
the
dynamic-fields-fetcher
branch
from
b081ff5 to
0901d04
Compare
MichaelSnowden
force-pushed
the
dynamic-fields-fetcher
branch
from
0901d04 to
c3bf450
Compare
yux0
approved these changes
Dec 8, 2022
rodrigozhou
approved these changes
Dec 8, 2022
|
Not sure if there's any value in creating a "Fetcher" for this vs just creating a function in mutable state. Not a big deal though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added a utility for fetching the memo and search attributes from a workflow, depending on whether the close visibility task is complete or not.
Why?
I made this change because we need this method in the new archival queue.
How did you test it?
I tested this change by adding unit tests.
Potential risks
This could introduce a bug into the DescribeWorkflowExecution API since the extracted method is slightly different so that it only depends on a visibility manager and mutable state.
Is hotfix candidate?
No.