Fix flaky CreateIndex method #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
es-flake-fix
branch
2 times, most recently
from
a669b88 to
6c3a9bb
Compare
mindaugasrukas
approved these changes
Dec 8, 2022
yux0
reviewed
Dec 8, 2022
| @@ -11,4 +11,4 @@ esconfig: | |||
| scheme: "http" | |||
| host: "${ES_SEEDS}:9200" | |||
| indices: | |||
| visibility: test-visibility- | |||
| visibility: test-visibility-3c863e | |||
There was a problem hiding this comment.
Thanks, fixed
yux0
approved these changes
Dec 8, 2022
MichaelSnowden
force-pushed
the
es-flake-fix
branch
from
6c3a9bb to
da52674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now use unique index names for ElasticSearch test configs.
Why?
Because this method is flaky, and my last effort to just retry the creation doesn't work. This lead to failed builds like this one.
How did you test it?
CI
Potential risks
This method is in the host/ directory which is only used by tests.
Is hotfix candidate?
No.