Disable the Test_DeleteExecutionsWorkflow_ManyExecutions_NoContinueAsNew test because it is flaky #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…New test because it is flaky
|
We have an internal task to fix this and re-enable the test. |
mindaugasrukas
approved these changes
Dec 8, 2022
alexshtin
added a commit
that referenced
this pull request
May 13, 2024
… test (#5912) ## What changed? <!-- Describe what has changed in this PR --> Reenable `Test_DeleteExecutionsWorkflow_ManyExecutions_NoContinueAsNew` test. ## Why? <!-- Tell your future self why have you made these changes --> Test was disabled in #3699 due to race condition. I used `atomic` and it constatnly passed. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ``` go test ./service/worker/deletenamespace/deleteexecutions -race -count 100 -json | jq -s 'map(select(.Action == "fail" and .Test))' ```
ychebotarev
pushed a commit
to ychebotarev/temporal
that referenced
this pull request
May 16, 2024
… test (temporalio#5912) ## What changed? <!-- Describe what has changed in this PR --> Reenable `Test_DeleteExecutionsWorkflow_ManyExecutions_NoContinueAsNew` test. ## Why? <!-- Tell your future self why have you made these changes --> Test was disabled in temporalio#3699 due to race condition. I used `atomic` and it constatnly passed. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ``` go test ./service/worker/deletenamespace/deleteexecutions -race -count 100 -json | jq -s 'map(select(.Action == "fail" and .Test))' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now skip Test_DeleteExecutionsWorkflow_ManyExecutions_NoContinueAsNew.
Why?
I did this because it is flaky.
How did you test it?
Potential risks
This could cause us to miss bugs that this test would have otherwise caught.
Is hotfix candidate?
No.