Fix errcheck warnings in cmd/tools #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
errcheck/cmd-tools
branch
from
03685cc to
3b088dc
Compare
dnr
reviewed
Dec 19, 2022
MichaelSnowden
force-pushed
the
errcheck/cmd-tools
branch
from
3b088dc to
040df2f
Compare
Makes sense, thanks. Fixed! |
dnr
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now handle all the unhandled errors in cmd/tools
Why?
Because we shouldn't have unhandled errors
How did you test it?
errcheck ./cmd/tools/...Potential risks
I am pretty sure this isn't run in production, only during development to generate the
*client_gen.gofiles.Is hotfix candidate?
No.