Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename mutableStateImpl receiver #3737

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

alexshtin
Copy link
Member

What changed?
Rename mutableStateImpl receiver from e to ms.

Why?
To better reflect the type name.

How did you test it?
Build.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner December 20, 2022 09:03
@alexshtin
Copy link
Member Author

С меня при цифре 37 в момент слетает хмель.
Вот и сейчас — как холодом подуло:
Под эту цифру Пушкин подгадал себе дуэль
И Маяковский лёг виском на дуло.
Задержимся на цифре 37! Коварен Бог —
Ребром вопрос поставил: или — или!
На этом рубеже легли и Байрон, и Рембо,
А нынешние как-то проскочили.

Copy link
Contributor

@MichaelSnowden MichaelSnowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this bugged me too

@alexshtin
Copy link
Member Author

С меня при цифре 37 в момент слетает хмель. Вот и сейчас — как холодом подуло: Под эту цифру Пушкин подгадал себе дуэль И Маяковский лёг виском на дуло. Задержимся на цифре 37! Коварен Бог — Ребром вопрос поставил: или — или! На этом рубеже легли и Байрон, и Рембо, А нынешние как-то проскочили.

At the number 37 the tipsiness flies off me in a trice,
Now it's just like a cold wind has blown,
At this number, Pushkin predicted a duel for himself
And Mayakovsky laid his temple on a barrel

Let's stick with the number 37. Insidious God
Put the question point-blank: you're either or.14
On this side of line passed Byron and Rimbeau,
Contemporary writers seem to have jumped across somehow.

@alexshtin alexshtin merged commit 6fbc4f4 into temporalio:master Dec 20, 2022
@alexshtin alexshtin deleted the feature/rename-ms-receiver branch December 20, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants