Fix errcheck in ./common/archiver/ #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Dec 21, 2022
| @@ -125,15 +126,16 @@ func (s *storageWrapper) Exist(ctx context.Context, URI archiver.URI, fileName s | |||
| } | |||
|
|
|||
| // Get retrieve a file | |||
| func (s *storageWrapper) Get(ctx context.Context, URI archiver.URI, fileName string) ([]byte, error) { | |||
| func (s *storageWrapper) Get(ctx context.Context, URI archiver.URI, fileName string) (bytes []byte, err error) { | |||
There was a problem hiding this comment.
Suggested change
| func (s *storageWrapper) Get(ctx context.Context, URI archiver.URI, fileName string) (bytes []byte, err error) { | |
| func (s *storageWrapper) Get(ctx context.Context, URI archiver.URI, fileName string) (fileContent []byte, err error) { |
There was a problem hiding this comment.
Fixed, thanks!
MichaelSnowden
force-pushed
the
errcheck/common/archiver
branch
from
38a0145 to
04bef26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
^
Why?
For code quality
How did you test it?
Reran errcheck
Potential risks
The listFiles method of our file store might start failing
Is hotfix candidate?
No