Consolidate linters with golangci-lint #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
linters/golangci-lint
branch
5 times, most recently
from
62d3e95 to
f282960
Compare
MichaelSnowden
force-pushed
the
linters/golangci-lint
branch
from
f282960 to
824f2fe
Compare
alexshtin
approved these changes
Dec 23, 2022
| @@ -264,7 +243,7 @@ shell-check: | |||
| @printf $(COLOR) "Run shellcheck for script files..." | |||
| @shellcheck $(ALL_SCRIPTS) | |||
|
|
|||
| check: copyright-check goimports-check lint vet staticcheck errcheck | |||
|
This is great! Thanks @MichaelSnowden for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In this PR, I added
golangci-lintto our repo, consolidating our compatible linters with this linter aggregator.Why?
I made this change for a few reasons:
--newoption which allows it to be applied only to new changes because we currently have a massive number of violations.golintis deprecatedHow did you test it?
I ran it locally and saw that only new errors were checked. I also tested it locally a few times using
act. To test this in a real example, I created a new branch here and verified that the annotations were published inline (on push), so we can see the annotations before the PR is even opened: d72112dPotential risks
Slows down dev to fix linter warnings.
Is hotfix candidate?
No