Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I turned on every linter for Revive except a few handpicked ones that I thought weren't useful.
Why?
We don't want to enable some useless linters like
exported
, but having linters likecyclomatic
for new code seem really useful.How did you test it?
I ran it locally. I also inspected the actual errors generated using this JQ query to see if they made sense:
Potential risks
It's just a linter
Is hotfix candidate?
No