Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in task channelWeightFn #3766

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Fix NPE in task channelWeightFn #3766

merged 2 commits into from
Dec 29, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Dec 29, 2022

What changed?

  • Error from GetNamespaceByID needs to be handled as it will return nil ptr. Previously the code is calling GetNamespaceName which returns empty name if namespace not found and error can be ignored.

Why?

  • Fix npe

How did you test it?

Potential risks

Is hotfix candidate?

  • Yes.

@yycptt yycptt added the release/1.19.1 Patches for v1.19.1 label Dec 29, 2022
@yycptt yycptt requested a review from a team as a code owner December 29, 2022 19:21
@yycptt yycptt force-pushed the fix-task-chan-weight-npe branch from 005c1ae to 2bd7241 Compare December 29, 2022 19:28
@yycptt yycptt merged commit adf7c54 into temporalio:master Dec 29, 2022
@yycptt yycptt deleted the fix-task-chan-weight-npe branch December 29, 2022 20:32
yycptt added a commit that referenced this pull request Dec 29, 2022
@yycptt
Fix NPE in task channelWeightFn (#3766)
6b2e448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
release/1.19.1 Patches for v1.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0