Deprecate old namespace change callback #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Jan 4, 2023
Comment on lines
-275
to
-284
|
|
||
| // failover callback will try to create a failover queue processor to scan all inflight tasks | ||
| // if domain needs to be failovered. However, in the multicursor queue logic, the scan range | ||
| // can't be retrieved before the processor is started. If failover callback is registered | ||
| // before queue processor is started, it may result in a deadline as to create the failover queue, | ||
| // queue processor need to be started. | ||
| // | ||
| // Ideally, when both timer and transfer queues enabled single cursor mode, we don't have to register | ||
| // the callback. However, currently namespace migration is relying on the callback to UpdateHandoverNamespaces | ||
| e.registerNamespaceFailoverCallback() |
There was a problem hiding this comment.
This change is from Cadence (cadence-workflow/cadence#3494) and should not be picked. It only applies to cadence version of multi-cursor implementation which still has the concept for failover queue.
| }, | ||
| ) | ||
| // for backward compatibility | ||
| _ = e.shard.UpdateNamespaceNotificationVersion(ns.NotificationVersion() + 1) |
There was a problem hiding this comment.
The impl of UpdateNamespaceNotificationVersion will make sure that stored notification version will never go back.
yux0
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?