Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connect clusters with different shards #3777

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jan 5, 2023

What changed?
Allow connect clusters with different shards

Why?
This is to support connect two clusters with different shard count.

How did you test it?
Unit tests.

Potential risks

Is hotfix candidate?
No

@yux0 yux0 requested a review from a team as a code owner January 5, 2023 06:13
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have plan for deprecating cluster management related APIs in admin handler?

@yux0
Copy link
Contributor Author

yux0 commented Jan 9, 2023

Do we have plan for deprecating cluster management related APIs in admin handler?

I think tctl v2 is using the operator APIs. Once we deprecate tctl v1, we can delete those APIs in admin handler.

@yux0 yux0 merged commit 3948854 into temporalio:master Jan 13, 2023
@yux0 yux0 deleted the allow-connection branch January 13, 2023 18:36
yux0 added a commit that referenced this pull request Jan 13, 2023
* Allow connect clusters with different shards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants