Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single scheduled queue max read level #3778

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Single scheduled queue max read level #3778

merged 3 commits into from
Jan 20, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jan 5, 2023

What changed?

  • scheduledTaskMaxReadLevelMap[cluster] -> scheduledTaskMaxReadLevel (only for current cluster)

Why?

  • With multi-cursor impl, we are only using scheduled queue max read level for the current cluster. So we don't need to maintain a separate max read level for each connected cluster.

How did you test it?

  • Existing test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yux0 January 5, 2023 22:37
@yycptt yycptt requested a review from a team as a code owner January 5, 2023 22:37
@yycptt yycptt merged commit 5175ab6 into temporalio:master Jan 20, 2023
@yycptt yycptt deleted the single-schedule-queue-max-read-level branch January 20, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0