Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture task processing panic #3779

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Capture task processing panic #3779

merged 1 commit into from
Jan 7, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jan 6, 2023 •
edited
Loading

What changed?

  • Capture task processing panic

Why?

  • We have panic wrapper for api handlers. Adding similar logic for task execution logic to prevent service from crashing when panic happens when processing tasks. The task will stuck and keep retrying (when we have dlq, it should go there), but service can continue to run and other tasks/workflows can still make progress.

How did you test it?

  • Unit test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from a team as a code owner January 6, 2023 01:42
@yycptt yycptt merged commit 3882bb6 into temporalio:master Jan 7, 2023
@yycptt yycptt deleted the capture-task-panic branch January 7, 2023 00:36
@yycptt yycptt added the release/1.19.1 Patches for v1.19.1 label Jan 12, 2023
yycptt added a commit that referenced this pull request Jan 12, 2023
@yycptt
Capture task processing panic (#3779)
c46fccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
release/1.19.1 Patches for v1.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0