Address a few linter errors #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Jan 6, 2023
| @@ -39,7 +39,7 @@ import ( | |||
| "go.temporal.io/server/common/persistence" | |||
| "go.temporal.io/server/common/quotas" | |||
| "go.temporal.io/server/common/timer" | |||
| "go.temporal.io/server/service/history/shard" | |||
| hshard "go.temporal.io/server/service/history/shard" | |||
There was a problem hiding this comment.
We only have the concept in history so I guess it is ok just use shard?
There was a problem hiding this comment.
The problem is that the shard identifier conflicts with many variables named shard.
For example: shard shard.Context
So I have two options:
- rename the identifier to something else
- rename all variables to something else (for example,
shardContext)
I think renaming the identifier is more readable.
What do you think?
There was a problem hiding this comment.
👍 I guess I am ok with either option. cc @yux0
There was a problem hiding this comment.
I see after the linter plugin.
yycptt
reviewed
Jan 6, 2023
yycptt
approved these changes
Jan 7, 2023
| @@ -39,7 +39,7 @@ import ( | |||
| "go.temporal.io/server/common/persistence" | |||
| "go.temporal.io/server/common/quotas" | |||
| "go.temporal.io/server/common/timer" | |||
| "go.temporal.io/server/service/history/shard" | |||
| hshard "go.temporal.io/server/service/history/shard" | |||
There was a problem hiding this comment.
👍 I guess I am ok with either option. cc @yux0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I fixed a few code quality errors that were annoying me:
Why?
Code quality
How did you test it?
CI
Potential risks
No
Is hotfix candidate?
Revert