Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewInternalErrorWithDPanic for common dpanic pattern #3797

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

yujieli-temporal
Copy link
Contributor

DPanic been introduced in our codebase, and the common pattern is:

in dev env -> panic
in prod env -> won't panic and have to return an error which stops the code to continue processing

Use DPanic pattern everywhere

Unittest, with prod and dev cfg

This change only introduce common pattern, haven't in use yet.

No

@yujieli-temporal yujieli-temporal requested a review from a team as a code owner January 11, 2023 00:11
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2023

CLA assistant check
All committers have signed the CLA.

@yujieli-temporal yujieli-temporal changed the title NO-JIRA | add common dpanic pattern Add common dpanic pattern Jan 11, 2023
@yujieli-temporal yujieli-temporal enabled auto-merge (squash) January 11, 2023 21:21
@yujieli-temporal yujieli-temporal changed the title Add common dpanic pattern Add NewInternalErrorWithDPanic for common dpanic pattern Jan 11, 2023
@yujieli-temporal yujieli-temporal merged commit 6319a28 into master Jan 11, 2023
@yujieli-temporal yujieli-temporal deleted the yujie/common-dpanic branch January 11, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants