Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support batch operation with list of workflow executions #3812

Merged
merged 7 commits into from
Jan 24, 2023

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jan 18, 2023

What changed?
Support batch operation with list of workflow executions

Why?
Support batch operation with list of workflow executions

How did you test it?
Add unit tests and verify the function locally.

Potential risks

Is hotfix candidate?

@yux0 yux0 requested a review from a team as a code owner January 18, 2023 23:20
@yux0 yux0 requested a review from yiminc January 18, 2023 23:21
Copy link
Contributor

@MichaelSnowden MichaelSnowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but I think we should add some test coverage before landing this

// Reason for the operation
Reason string
// Supporting: signal,cancel,terminate
// Supporting: signal,cancel,terminate,delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes I hope there's a type for workflow refresh as well :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should. Let's track this somewhere.

@yux0 yux0 merged commit 9389673 into temporalio:master Jan 24, 2023
@yux0 yux0 deleted the batch-executions branch January 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants