-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch operation with list of workflow executions #3812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, but I think we should add some test coverage before landing this
// Reason for the operation | ||
Reason string | ||
// Supporting: signal,cancel,terminate | ||
// Supporting: signal,cancel,terminate,delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sometimes I hope there's a type for workflow refresh as well :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should. Let's track this somewhere.
What changed?
Support batch operation with list of workflow executions
Why?
Support batch operation with list of workflow executions
How did you test it?
Add unit tests and verify the function locally.
Potential risks
Is hotfix candidate?