[Advanced Visibility with SQL] Changing visibility schema for SQLite #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
advanced-visibility-sqlite-schema
branch
2 times, most recently
from
b9ee3ac to
7807eb9
Compare
rodrigozhou
changed the title
yiminc
reviewed
Jan 26, 2023
rodrigozhou
force-pushed
the
advanced-visibility-sqlite-schema
branch
4 times, most recently
from
a3540cf to
967904b
Compare
alexshtin
approved these changes
Jan 31, 2023
dnr
reviewed
Jan 31, 2023
| TemporalScheduledStartTime TIMESTAMP GENERATED ALWAYS AS (STRFTIME('%Y-%m-%d %H:%M%:%f+00:00', JSON_EXTRACT(search_attributes, "$.TemporalScheduledStartTime"))), | ||
| TemporalScheduledById VARCHAR(255) GENERATED ALWAYS AS (JSON_EXTRACT(search_attributes, "$.TemporalScheduledById")), | ||
| TemporalSchedulePaused BOOLEAN GENERATED ALWAYS AS (JSON_EXTRACT(search_attributes, "$.TemporalSchedulePaused")), | ||
| TemporalNamespaceDivision VARCHAR(255) GENERATED ALWAYS AS (JSON_EXTRACT(search_attributes, "$.TemporalNamespaceDivision")), |
There was a problem hiding this comment.
Is it going to be easy to add new generated fields here, e.g. if we add a new feature like schedules that uses a handful of new predefined search attributes? Will we need to add v4 of the schema or just write a small migration?
There was a problem hiding this comment.
The v3 means sqlite3, not the schema version. We don't track schema version for sqlite, only for MySQL and PostgreSQL, in which case, you'll need to write scripts to update the schema.
rodrigozhou
force-pushed
the
advanced-visibility-sqlite-schema
branch
from
967904b to
2f9a5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed SQLite visibility schema to support advanced visibility:
Why?
Advanced visibility with SQL databases.
How did you test it?
Existing tests.
Started temporal using SQLite, and ran some samples.
Potential risks
No risks in production, only affects when using with SQLite.
Is hotfix candidate?
No.