Add GetIndexName method to visibility manager #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
vis-manager-get-index-name
branch
2 times, most recently
from
306e25d to
1897988
Compare
rodrigozhou
force-pushed
the
vis-manager-get-index-name
branch
from
1897988 to
fe9114b
Compare
alexshtin
approved these changes
Jan 25, 2023
rodrigozhou
force-pushed
the
vis-manager-get-index-name
branch
4 times, most recently
from
cea02f1 to
a50f1b0
Compare
rodrigozhou
force-pushed
the
vis-manager-get-index-name
branch
from
a50f1b0 to
3b7973c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a interface to get the visibility storage schema name, ie., for ES the index name, and for SQL DB the table name.
Why?
It will allow to abstract the schema name without needing to read from config. The visibility manager already is an abstraction of the underlying storage, so it makes it easier to get the schema name.
How did you test it?
Unit tests
Potential risks
Maybe will have some issue with cluster metadata when using SQL DB since it was using empty string as "index name".
Is hotfix candidate?
No.