Produce archival tasks conditionally #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Jan 23, 2023
yux0
reviewed
Jan 24, 2023
MichaelSnowden
force-pushed
the
snowden/produce-archival-task-conditionally
branch
from
c3af4ab to
b4cb9ad
Compare
MichaelSnowden
force-pushed
the
snowden/produce-archival-task-conditionally
branch
from
b4cb9ad to
d979191
Compare
yux0
approved these changes
Jan 24, 2023
MichaelSnowden
deleted the
snowden/produce-archival-task-conditionally
branch
MichaelSnowden
added a commit
that referenced
this pull request
Jan 31, 2023
MichaelSnowden
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now produce archival queue tasks only if archival and the archival queue are enabled.
Why?
Durable archival will soon be on by default, but there's only a point in producing these tasks if archival itself is enabled.
How did you test it?
I wrote several new test cases in the task_generator.
Potential risks
This adds a new check to our task generator, and if there's an NPE at some point, that could break production. However, this will only happen if the archival metadata on the cluster or the namespace is nil.
Is hotfix candidate?
No