Mark state transition & completion metrics with namespace activeness #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
approved these changes
Jan 24, 2023
yux0
approved these changes
Jan 24, 2023
| ).Record( | ||
| mutableState.GetExecutionInfo().StateTransitionCount, | ||
| metrics.NamespaceTag(namespaceEntry.Name().String()), | ||
| metrics.NamespaceStateTag(namespaceState(clusterMetadata, convert.Int64Ptr(mutableState.GetCurrentVersion()))), |
There was a problem hiding this comment.
nit: MutableStateFailoverVersion(mutableState)?
yiminc
approved these changes
Jan 25, 2023
hehaifengcn
reviewed
Jan 25, 2023
| } | ||
|
|
||
| // default value, need to special handle | ||
| if *mutableStateCurrentVersion == 0 { |
There was a problem hiding this comment.
nit: I think logic can be shorten as
if (*mutableStateCurrentVersion == 0) || clusterMetadata.IsVersionFromSameCluster(...) {
return namespaceStateActive
}
any reason to pass mutableStateCurrentVersion as a pointer instead of just scalar value?
| newWorkflowSnapshot *persistence.WorkflowSnapshot, | ||
| newWorkflowEventsSeq []*persistence.WorkflowEvents, | ||
| ) (int64, error) | ||
|
|
||
| ConflictResolveWorkflowExecution( | ||
| ctx context.Context, | ||
| conflictResolveMode persistence.ConflictResolveWorkflowMode, | ||
| resetWorkflowFailoverVersion int64, |
There was a problem hiding this comment.
should we just pass all FailoverVersions as int64 to be consistent here?
| namespaceStateUnknown = "_unknown_" | ||
| ) | ||
|
|
||
| func namespaceState( |
There was a problem hiding this comment.
nit: rename to something like getNamespaceState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Better metrics
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
N/A